Re: [Qemu-devel] [PATCH v4 12/23] block: Rename BlockDriverCompletionFunc to BlockCompletionFunc

[Markus Armbruster]

Max Reitz <address@hidden> writes:

> On 30.09.2014 21:25, Markus Armbruster wrote:
>> I'll use it with block backends shortly, and the name is going to fit
>> badly there.  It's a block layer thing anyway, not just a block driver
>> thing.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>   block.c                     | 30 +++++++++++++++---------------
>>   block/archipelago.c         |  8 ++++----
>>   block/backup.c              |  2 +-
>>   block/blkdebug.c            |  8 ++++----
>>   block/blkverify.c           |  8 ++++----
>>   block/commit.c              |  2 +-
>>   block/curl.c                |  2 +-
>>   block/iscsi.c               |  2 +-
>>   block/linux-aio.c           |  2 +-
>>   block/mirror.c              |  6 +++---
>>   block/null.c                |  8 ++++----
>>   block/qed-gencb.c           |  4 ++--
>>   block/qed-table.c           | 10 +++++-----
>>   block/qed.c                 | 18 +++++++++---------
>>   block/qed.h                 | 10 +++++-----
>>   block/quorum.c              |  6 +++---
>>   block/raw-aio.h             |  4 ++--
>>   block/raw-posix.c           | 16 ++++++++--------
>>   block/raw-win32.c           |  8 ++++----
>>   block/raw_bsd.c             |  2 +-
>>   block/rbd.c                 | 10 +++++-----
>>   block/stream.c              |  2 +-
>>   block/win32-aio.c           |  2 +-
>>   blockjob.c                  |  4 ++--
>>   dma-helpers.c               |  2 +-
>>   hw/ide/ahci.c               |  2 +-
>>   hw/ide/core.c               |  4 ++--
>>   hw/ide/internal.h           |  6 +++---
>>   hw/ide/macio.c              |  2 +-
>>   hw/ide/pci.c                |  2 +-
>>   hw/ide/pci.h                |  2 +-
>>   hw/scsi/scsi-generic.c      |  2 +-
>>   include/block/aio.h         |  6 +++---
>>   include/block/block.h       | 14 +++++++-------
>>   include/block/block_int.h   | 20 ++++++++++----------
>>   include/block/blockjob.h    |  4 ++--
>>   include/block/thread-pool.h |  2 +-
>>   include/monitor/monitor.h   |  4 ++--
>>   include/sysemu/dma.h        |  8 ++++----
>>   monitor.c                   |  6 +++---
>>   thread-pool.c               |  2 +-
>>   41 files changed, 131 insertions(+), 131 deletions(-)
>
> I requested some trivial changes to patch 11 and rebasing this patch
> unto it will result in some trivial "functional" changes, if you heed
> my requests. Those should only be alignment changes, however (even the
> hunk in scsi-generic.c). In addition, docs/blkdebug.txt mentions
> BlockDriverCompletionFunc. Thus, like patch 11, this patch should
> replace that occurrence as well.
>
> With these trivial changes (alignment changes due to rebasing on a
> patch 11 changed according to my proposals and the replacement in
> docs/blkdebug.txt):
>
> Reviewed-by: Max Reitz <address@hidden>

Done, thanks!