qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 leve


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 0/6] pc: bring ACPI table size below to 2.0 levels, try fixing -initrd for good
Date: Mon, 6 Oct 2014 17:12:31 +0300

On Mon, Oct 06, 2014 at 03:55:49PM +0200, Paolo Bonzini wrote:
> Il 06/10/2014 15:52, Michael S. Tsirkin ha scritto:
> > Maybe we should just modify ACPI and rom files in general to use
> > something else, not RAM?
> > It looked like a good fit initially so we went ahead with it,
> > but these things are fairly small, so it's not a problem to
> > migrate them as part of the device state.
> 
> Yes, that would have been a good design too, but I'm not sure it's worth
> changing it now.  So far, it has certainly helped us; it both revealed
> bugs (though a bit too late) and kept us honest.

Bugs that surface too late is exactly what worries me.
I'll try to look at how hard to implement the above change is.

> These patches would be easy to revert from now till 2.2 release, they're
> just an incremental improvement on top of 2.1.2.
> 
> I'll post a v2 that includes the linuxboot changes to look at the memory
> map,

Pls keep linuxboot things a separate patchset.

> and keep the 160k padding for the sake of old linuxboot option ROMs
> being migrated to 2.2.
> 
> Paolo

I think we can drop this for 2.2 machine type.
We can also drop the fw cfg file for new machine types.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]