Re: [Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error reporting

[Paolo Bonzini]

Il 08/10/2014 14:11, address@hidden ha scritto:
> This version makes the error message reporting more sane and
> adds a error_vreport() to make that easier.
> 
> It also cleans up the bool handling.
> 
> This depends on the previos non-blocking socket changes, which
> should hopefully be in qemu soon.

Looks good, but let's unify the error message like this:

+static void check_report_connect_error(CharDriverState *chr,
+                                       Error *err)
+{
+    TCPCharDriver *s = chr->opaque;
+
+    if (!s->connect_err_reported) {
+        error_report("Unable to connect character device %s: %s",
+                     chr->label, error_get_pretty(err));
+        s->connect_err_reported = true;
+    }
+    qemu_chr_socket_restart_timer(chr);
+}
+

This is an error on connecting the character device to the backend.  The
error on the socket is already detailed after the colon, thanks to your
patch 2.

I'll send a pull request today or tomorrow.

Thanks,

Paolo