Re: [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container

[Markus Armbruster]

Zhu Guihua <address@hidden> writes:

> On Wed, 2014-10-08 at 10:01 +0200, Paolo Bonzini wrote:
>> Il 08/10/2014 05:49, Zhu Guihua ha scritto:
>> > when device_add pc-dimm, only 'memdev' property is necessary, but the
>> > 'id' property is optional. 
>> > 
>> > So I execute the command as followings:
>> > object_add memory-backend-ram,id=ram0,size=128M
>> > device_add pc-dimm,memdev=ram0
>> > 
>> > Now it is impossible to delete the pc-dimm, because it has no id, and it
>> > is inside of 'peripheral-anon' container. 
>> 
>> Sure; but that was an explicit choice when you issued device_add.
>
> Thanks for your patient explanation。
> And I think it is better to make memory-devices without dev->id use
> auto-generated IDs.

Auto-generated IDs have been discussed and rejected several times.  At
the very least, clashes with user-specified IDs must be impossible.