qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from q


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom
Date: Thu, 09 Oct 2014 13:15:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

Il 07/10/2014 10:00, address@hidden ha scritto:
> From: Gonglei <address@hidden>
> 
> Remove bootindex form qdev property to qom, things will
> continue to work just fine, and we can use qom features
> which are not supported by qdev property.
> 
> Signed-off-by: Gonglei <address@hidden>
> Reviewed-by: Gerd Hoffmann <address@hidden>
> ---
>  include/net/net.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/net/net.h b/include/net/net.h
> index ed594f9..008d610 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -36,8 +36,7 @@ typedef struct NICConf {
>  #define DEFINE_NIC_PROPERTIES(_state, _conf)                            \
>      DEFINE_PROP_MACADDR("mac",   _state, _conf.macaddr),                \
>      DEFINE_PROP_VLAN("vlan",     _state, _conf.peers),                   \
> -    DEFINE_PROP_NETDEV("netdev", _state, _conf.peers),                   \
> -    DEFINE_PROP_INT32("bootindex", _state, _conf.bootindex, -1)
> +    DEFINE_PROP_NETDEV("netdev", _state, _conf.peers)
>  
>  
>  /* Net clients */
> 

This is a bit of a pity, and it's caused by the different nature of QOM
properties (instance-based) vs. qdev properties (class-based).

I can live with that.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]