[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL i
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct |
Date: |
Fri, 10 Oct 2014 17:19:56 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/10/10 16:47, Cornelia Huck wrote:
> On Thu, 9 Oct 2014 12:17:30 +0200
> Paolo Bonzini <address@hidden> wrote:
>
>> From: Eduardo Habkost <address@hidden>
>>
>> Now that we create an accel object before calling machine_init, we can
>> simply use the accel object to save all KVMState data, instead of
>> allocationg KVMState manually.
>>
>> Reviewed-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Eduardo Habkost <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> kvm-all.c | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> This patch breaks compilation on s390 for me:
>
> CC s390x-softmmu/kvm-all.o
> /home/cohuck/git/qemu/kvm-all.c:110: error: redefinition of typedef ‘KVMState’
> /home/cohuck/git/qemu/include/sysemu/kvm.h:161: error: previous declaration
> of ‘KVMState’ was here
>
>
I encountered this issue too [gcc version 4.3.4 [gcc-4_3-branch revision
152973] (SUSE Linux) ]:
CC m68k-softmmu/cputlb.o
CC mips64-softmmu/memory.o
/home/qemu/kvm-all.c:110: error: redefinition of typedef 'KVMState'
/home/qemu/include/sysemu/kvm.h:161: error: previous declaration of 'KVMState'
was here
CC arm-softmmu/memory.o
make[1]: *** [kvm-all.o] Error 1
make: *** [subdir-i386-softmmu] Error 2
make: *** Waiting for unfinished jobs....
CC mips64-softmmu/savevm.o
CC or32-softmmu/cputlb.o
CC microblaze-softmmu/cputlb.o
CC xtensaeb-softmmu/cputlb.o
CC mips64el-softmmu/savevm.o
CC ppcemb-softmmu/ioport.o
CC sh4-softmmu/savevm.o
CC ppc-softmmu/ioport.o
CC aarch64-softmmu/device_tree.o
CC mips-softmmu/savevm.o
CC cris-softmmu/cputlb.o
CC microblazeel-softmmu/cputlb.o
CC sparc-softmmu/cputlb.o
CC sh4eb-softmmu/cputlb.o
/home/qemu/kvm-all.c:110: error: redefinition of typedef 'KVMState'
/home/qemu/include/sysemu/kvm.h:161: error: previous declaration of 'KVMState'
was here
Best regards,
-Gonglei
- [Qemu-devel] [PULL 20/28] accel: Rename 'init' method to 'init_machine', (continued)
- [Qemu-devel] [PULL 20/28] accel: Rename 'init' method to 'init_machine', Paolo Bonzini, 2014/10/09
- [Qemu-devel] [PULL 22/28] accel: Create accel object when initializing machine, Paolo Bonzini, 2014/10/09
- [Qemu-devel] [PULL 21/28] accel: Pass MachineState object to accel init functions, Paolo Bonzini, 2014/10/09
- [Qemu-devel] [PULL 26/28] qemu-error: Add error_vreport(), Paolo Bonzini, 2014/10/09
- [Qemu-devel] [PULL 27/28] qemu-sockets: Add error to non-blocking connect handler, Paolo Bonzini, 2014/10/09
- [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct, Paolo Bonzini, 2014/10/09
- Re: [Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct,
Gonglei <=
[Qemu-devel] [PULL 28/28] qemu-char: Fix reconnect socket error reporting, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 25/28] virtio-scsi: fix use-after-free of VirtIOSCSIReq, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 24/28] linuxboot: compute initrd loading address, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 07/28] vl.c: Small coding style fix, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 16/28] accel: Move Xen registration code to xen-common.c, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 15/28] accel: Move KVM accel registration to kvm-all.c, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 10/28] accel: Simplify configure_accelerator() using AccelType *acc variable, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 11/28] accel: Move accel name lookup to separate function, Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 14/28] accel: Report unknown accelerator as "not found" instead of "does not exist", Paolo Bonzini, 2014/10/09
[Qemu-devel] [PULL 12/28] accel: Use QOM classes for accel types, Paolo Bonzini, 2014/10/09