[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS |
Date: |
Mon, 20 Oct 2014 12:40:02 +0300 |
(((sid) >> 8) && 0xff) makes no sense
(((sid) >> 8) & 0xff) seems to be what was meant.
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
Compile-tested only.
include/hw/i386/intel_iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index f4701e1..e321ee4 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -37,7 +37,7 @@
#define VTD_PCI_DEVFN_MAX 256
#define VTD_PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
#define VTD_PCI_FUNC(devfn) ((devfn) & 0x07)
-#define VTD_SID_TO_BUS(sid) (((sid) >> 8) && 0xff)
+#define VTD_SID_TO_BUS(sid) (((sid) >> 8) & 0xff)
#define VTD_SID_TO_DEVFN(sid) ((sid) & 0xff)
#define DMAR_REG_SIZE 0x230
--
MST
- [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS, Markus Armbruster, 2014/10/20
- Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS, Knut Omang, 2014/10/20
- Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS, Jan Kiszka, 2014/10/20
- Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS, Knut Omang, 2014/10/20
- Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS, Knut Omang, 2014/10/20