Re: [Qemu-devel] [PATCH v2 1/9] target-mips: add KScratch registers

[Leon Alrae]

Hi Yongbok,

On 14/10/2014 14:59, Yongbok Kim wrote:
>> @@ -4611,6 +4612,15 @@ static inline void gen_mtc0_store64 (TCGv arg,
>> target_ulong off)
>>       tcg_gen_st_tl(arg, cpu_env, off);
>>   }
>>   +static inline void gen_mfc0_unimplemented(DisasContext *ctx, TCGv arg)
>> +{
>> +    if (ctx->insn_flags & ISA_MIPS32R6) {
>> +        tcg_gen_movi_tl(arg, 0);
>> +    } else {
>> +        tcg_gen_movi_tl(arg, ~0);
>> +    }
>> +}
>> +
> 
> Not related with KScratch registers. It would be better to be a separate
> patch or
> as part of the patch [PATCH 5/6] target-mips: correctly handle access to
> unimplemented CP0 register.

Actually it is related to all cp0 registers and KScratch is the first
cp0 register added in the series, thus in my opinion this is a good
place for including the definition of gen_mfc0_unimplemented(). The
patch you mentioned is correcting the remaining (existing before this
patch) cp0 registers.

Regards,
Leon