[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 0
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041 |
Date: |
Thu, 23 Oct 2014 12:06:32 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben:
> As of a follow-up patch to this one, the length of a mirror block job
> will no longer directly depend on the size of the block device;
> therefore, drop these checks from this test. Instead, just check whether
> the final offset equals the block job length.
>
> As 041 uses the wait_until_completed function from iotests.py, the same
> applies there as well which in turn affects tests 030, 055 and 056. On
> the other hand, a block job's length does not have to be related to the
> length of the image file in the first place, so that check was
> questionable anyway.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Possibly a result of rebasing over a long time, but 041 still has some
checks of len left after this patch.
Kevin
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), (continued)
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Kevin Wolf, 2014/10/23
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Max Reitz, 2014/10/23
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Kevin Wolf, 2014/10/23
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Max Reitz, 2014/10/23
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Kevin Wolf, 2014/10/23
- Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty(), Max Reitz, 2014/10/23
[Qemu-devel] [PATCH v13 04/14] blockjob: Introduce block_job_complete_sync(), Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 05/14] blockjob: Add "ready" field, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041, Max Reitz, 2014/10/22
- Re: [Qemu-devel] [PATCH v13 06/14] iotests: Omit length/offset test in 040 and 041,
Kevin Wolf <=
[Qemu-devel] [PATCH v13 07/14] block/mirror: Improve progress report, Max Reitz, 2014/10/22
[Qemu-devel] [PATCH v13 08/14] qemu-img: Implement commit like QMP, Max Reitz, 2014/10/22