[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Make qemu_shutdown_requested signal-safe
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Make qemu_shutdown_requested signal-safe |
Date: |
Mon, 27 Oct 2014 10:09:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/26/2014 10:32 AM, Jan Kiszka wrote:
> From: Jan Kiszka <address@hidden>
>
> qemu_shutdown_requested may be interrupted by qemu_system_killed.
> If the latter sets shutdown_requested after qemu_shutdown_requested
> has read it but before it was cleared, the shutdown event is lost.
> Fix this by using atomic_xchg.
>
> Signed-off-by: Jan Kiszka <address@hidden> --- vl.c | 4
> +--- 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/vl.c b/vl.c index 2f81384..f6b3546 100644 --- a/vl.c
> +++ b/vl.c @@ -1609,9 +1609,7 @@ int
> qemu_reset_requested_get(void)
>
> static int qemu_shutdown_requested(void) { - int r =
> shutdown_requested; - shutdown_requested = 0; - return r; +
> return atomic_xchg(&shutdown_requested, 0); }
>
> static void qemu_kill_report(void)
>
Cc: address@hidden
Reviewed-by: Paolo Bonzini <address@hidden>
Are you going to send a pull request yourself?