[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throu
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits |
Date: |
Mon, 27 Oct 2014 10:18:47 +0100 |
As Max pointed out there is a hidden cast from int64_t to int for all
limits. So use the newly introduced sector_limits_lun2qemu for all
limits received from the target.
Signed-off-by: Peter Lieven <address@hidden>
---
block/iscsi.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 6b229b1..a4ba33b 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1468,23 +1468,23 @@ static void iscsi_refresh_limits(BlockDriverState *bs,
Error **errp)
if (iscsilun->lbp.lbpu) {
if (iscsilun->bl.max_unmap < 0xffffffff) {
- bs->bl.max_discard = sector_lun2qemu(iscsilun->bl.max_unmap,
- iscsilun);
+ bs->bl.max_discard =
+ sector_limits_lun2qemu(iscsilun->bl.max_unmap, iscsilun);
}
- bs->bl.discard_alignment = sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
- iscsilun);
+ bs->bl.discard_alignment =
+ sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
}
if (iscsilun->bl.max_ws_len < 0xffffffff) {
- bs->bl.max_write_zeroes = sector_lun2qemu(iscsilun->bl.max_ws_len,
- iscsilun);
+ bs->bl.max_write_zeroes =
+ sector_limits_lun2qemu(iscsilun->bl.max_ws_len, iscsilun);
}
if (iscsilun->lbp.lbpws) {
- bs->bl.write_zeroes_alignment =
sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
- iscsilun);
+ bs->bl.write_zeroes_alignment =
+ sector_limits_lun2qemu(iscsilun->bl.opt_unmap_gran, iscsilun);
}
- bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
- iscsilun);
+ bs->bl.opt_transfer_length =
+ sector_limits_lun2qemu(iscsilun->bl.opt_xfer_len, iscsilun);
}
/* Since iscsi_open() ignores bdrv_flags, there is nothing to do here in
--
1.7.9.5
- [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 2/6] BlockLimits: introduce max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 1/6] util: introduce MIN_NON_ZERO, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 4/6] block: avoid creating oversized writes in multiwrite_merge, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 3/6] block/iscsi: set max_transfer_length, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 6/6] block/iscsi: check for oversized requests, Peter Lieven, 2014/10/27
- [Qemu-devel] [PATCHv6 5/6] block/iscsi: use sector_limits_lun2qemu throughout iscsi_refresh_limits,
Peter Lieven <=
- Re: [Qemu-devel] [PATCHv6 0/6] introduce max_transfer_length, Stefan Hajnoczi, 2014/10/28