[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support |
Date: |
Mon, 3 Nov 2014 14:34:32 +0200 |
On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote:
>
> On 02/11/2014 11:19, Michael S. Tsirkin wrote:
> > > Add AVX512 feature bits, register definition and corresponding
> > > xsave/vmstate support.
> > >
> > > Signed-off-by: Chao Peng <address@hidden>
> >
> > Thanks!
> >
> > As this was first posted after soft freeze, please
> > resubmit after 2.2 is out.
> >
> > See schedule http://wiki.qemu.org/Planning/2.2
>
> Actually this is already in.
>
> While "Planning/2.2" says "all features should have patches posted on
> the mailing list", the actual page describing soft feature freeze is
> more lenient:
>
> By the date of the soft feature freeze, any non-trivial feature
> should have some code posted to the qemu-devel mailing list if it's
> targeting a given release. Major features, and in particular
> features with a high likelihood of breaking things, should already
> be in the process of being merged.
>
> This patch was fairly trivial, as it only adds a few memcpys and a
> subsection. Likelihood of breaking things is basically zero because
> AVX512 does not yet exist in silicon. Eduardo reviewed the patch
> promptly and agreed with putting it in 2.2, so that's what I did.
>
> Paolo
Oh that's fine.
I was not trying to argue, I didn't notice it was in
and thought I'm asked to merge it.
It's always a judgement call, I trust you did the right thing.
Thanks and sorry about the noise.
--
MST