[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: changed to proper enum type
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] block: changed to proper enum type |
Date: |
Mon, 03 Nov 2014 17:14:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 31/10/2014 05:52, SeokYeon Hwang wrote:
> To fix compiler warning on clang > 3.4, changed to proper enum type.
>
> Signed-off-by: SeokYeon Hwang <address@hidden>
> ---
> block.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/block.c b/block.c
> index 88f6d9b..50845a4 100644
> --- a/block.c
> +++ b/block.c
> @@ -3540,10 +3540,10 @@ static void send_qmp_error_event(BlockDriverState *bs,
> BlockErrorAction action,
> bool is_read, int error)
> {
> - BlockErrorAction ac;
> + IoOperationType operation;
>
> - ac = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE;
> - qapi_event_send_block_io_error(bdrv_get_device_name(bs), ac, action,
> + operation = is_read ? IO_OPERATION_TYPE_READ : IO_OPERATION_TYPE_WRITE;
> + qapi_event_send_block_io_error(bdrv_get_device_name(bs), operation,
> action,
> bdrv_iostatus_is_enabled(bs),
> error == ENOSPC, strerror(error),
> &error_abort);
>
Hi, I think a similar patch has already been posted.
Paolo