Re: [Qemu-devel] [PATCH v6 09/10] qmp: Add dirty bitmap 'enabled' field in query-block

[Max Reitz]

On 2014-10-30 at 04:22, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>   block.c              | 1 +
>   qapi/block-core.json | 5 ++++-
>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index e574faa..f4d145c 100644
> --- a/block.c
> +++ b/block.c
> @@ -5375,6 +5375,7 @@ BlockDirtyInfoList 
> *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
>               ((int64_t) BDRV_SECTOR_SIZE << hbitmap_granularity(bm->bitmap));

Although just context, this could use bdrv_dirty_bitmap_granularity() or 
bm->granularity.

>           info->has_name = !!bm->name;
>           info->name = info->has_name ? g_strdup(bm->name) : NULL;
> +        info->enabled = bm->enabled;
>           entry->value = info;
>           *plist = entry;
>           plist = &entry->next;
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e225220..edd74c8 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -313,10 +313,13 @@
>   #
>   # @granularity: granularity of the dirty bitmap in bytes (since 1.4)
>   #
> +# @enabled: whether the dirty bitmap is enabled (Since 2.3)
> +#
>   # Since: 1.3
>   ##
>   { 'type': 'BlockDirtyInfo',
> -  'data': {'*name': 'str', 'count': 'int', 'granularity': 'int'} }
> +  'data': {'*name': 'str', 'count': 'int', 'granularity': 'int',
> +           'enabled': 'bool'} }
>   
>   ##
>   # @BlockInfo:

Reviewed-by: Max Reitz <address@hidden>