qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] block: Read only one sector for format prob


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 2/4] block: Read only one sector for format probing
Date: Tue, 4 Nov 2014 15:32:52 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Oct 30, 2014 at 01:26:14PM +0100, Kevin Wolf wrote:
> The only image format driver that even potentially accesses anything
> after 512 bytes in its bdrv_probe() implementation is VMDK, which reads
> a plain-text descriptor file. In practice, the field it's looking for
> seems to come first and will be well within the first 512 bytes, too.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                   | 2 +-
>  include/block/block_int.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)

I tried to find a logical reason for the historical 1024 and 2048 byte
sizes but it's not clear.  512 should be fine.

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: pgpCN3QqfICri.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]