Re: [Qemu-devel] [PATCH 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

[Xu, Quan]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Tuesday, November 04, 2014 11:55 PM
> To: Xu, Quan; address@hidden
> Cc: address@hidden; address@hidden; address@hidden
> Subject: Re: [Qemu-devel] [PATCH 1/4] Qemu-Xen-vTPM: Support for Xen
> stubdom vTPM command line options
> 
> On 11/02/2014 07:39 AM, Quan Xu wrote:
> 
> [meta-comment] This message appears to have a cover letter; but you failed
> to properly set the 'In-Reply-To' header; when each patch of your series
> appears as a top-level thread instead of a reply to the cover letter, it is 
> harder
> to review.
> 
:(
Thanks Eric. 
Markus (Markus Armbruster <address@hidden>) shared how he formats and sends a 
patch series.
I will submit v2 in the right format. 

> > Signed-off-by: Quan Xu <address@hidden>
> > ---
> >  configure        | 14 ++++++++++++++
> >  hmp.c            |  7 +++++++
> >  qapi-schema.json | 17 +++++++++++++++--  qemu-options.hx  | 13
> > +++++++++++--
> >  tpm.c            |  7 ++++++-
> >  5 files changed, 53 insertions(+), 5 deletions(-)
> >
> 
> > +++ b/qapi-schema.json
> > @@ -2853,10 +2853,11 @@
> >  # An enumeration of TPM types
> >  #
> >  # @passthrough: TPM passthrough type
> > +# @xenstubdoms: TPM xenstubdoms type
> 
> Missing a '(since 2.3)' designation.

I will add it in v2.

> 
> >  #
> >  # Since: 1.5
> >  ##
> > -{ 'enum': 'TpmType', 'data': [ 'passthrough' ] }
> > +{ 'enum': 'TpmType', 'data': [ 'passthrough', 'xenstubdoms' ] }
> >
> >  ##
> >  # @query-tpm-types:
> > @@ -2884,6 +2885,16 @@
> >  { 'type': 'TPMPassthroughOptions', 'data': { '*path' : 'str',
> >                                               '*cancel-path' : 'str'}
> > }
> >
> > +# @TPMXenstubdomsOptions:
> > +#
> > +# Information about the TPM xenstubdoms type # # Since: > 2.1.0
> 
> 2.1 is wrong; the earliest you can get this into the tree is 2.3 (because 
> you've
> missed soft freeze for 2.2).

I will fix it in v2. 

> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org