Re: [Qemu-devel] [PATCH v2] libqos: Convert malloc-pc allocator to a generic allocator

[John Snow]

On 10/23/2014 04:12 AM, Marc Marí wrote:
> The allocator in malloc-pc has been extracted, so it can be used in every arch.
> This operation showed that both the alloc and free functions can be also
> generic.
> Because of this, the QGuestAllocator has been removed from is function to wrap
> the alloc and free function, and now just contains the allocator parameters.
> As a result, only the allocator initalizer and unitializer are arch dependent.
>
> Signed-off-by: Marc Marí <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
>   tests/Makefile           |    2 +-
>   tests/libqos/malloc-pc.c |  280 +---------------------------------------------
>   tests/libqos/malloc-pc.h |   11 +-
>   tests/libqos/malloc.c    |  270 ++++++++++++++++++++++++++++++++++++++++++++
>   tests/libqos/malloc.h    |   45 +++++---
>   5 files changed, 309 insertions(+), 299 deletions(-)
>   create mode 100644 tests/libqos/malloc.c
[snip]

I previously acknowledged V1 mistakenly instead of V2 here, and have 
seen no activity since -- so here's another Reviewed-by in case someone 
has a script waiting for this explicit reply.

I'll also add that I pulled the patch into my testing tree and ran it 
through Valgrind and my AHCI test suite and it behaves perfectly well.

Reviewed-by: John Snow <address@hidden>