[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and funct
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs |
Date: |
Fri, 07 Nov 2014 11:44:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/07/2014 11:31 AM, Pavel Dovgalyuk wrote:
> This patch adds global variables, defines, functions declarations,
> and function stubs for deterministic VM replay used by external modules.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
Just focusing on interface review:
> +++ b/qapi-schema.json
> @@ -3508,3 +3508,35 @@
> # Since: 2.1
> ##
> { 'command': 'rtc-reset-reinjection' }
> +
> +##
> +# ReplayMode:
> +#
> +# Mode of the replay subsystem.
> +#
> +# @none: normal execution mode. Replay or record are not enabled.
> +#
> +# @record: record mode. All non-deterministic data is written into the
> +# replay log.
> +#
> +# @play: replay mode. Non-deterministic data required for system execution
> +# is read from the log.
> +#
> +# Since: 2.2
You've missed 2.2 freeze; this will have to be 2.3.
> +##
> +{ 'enum': 'ReplayMode',
> + 'data': [ 'none', 'record', 'play' ] }
> +
> +##
> +# ReplaySubmode:
> +#
> +# Submode of the replay subsystem.
> +#
> +# @unknown: used for modes different from play.
> +#
> +# @normal: normal replay mode.
> +#
> +# Since: 2.2
Again, 2.3
> +##
> +{ 'enum': 'ReplaySubmode',
> + 'data': [ 'unknown', 'normal' ] }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH v4 00/25] Deterministic replay and reverse execution, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 01/25] acpi: accurate overflow check, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 02/25] mc146818rtc: add missed field to vmstate, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs, Pavel Dovgalyuk, 2014/11/07
- Re: [Qemu-devel] [RFC PATCH v4 03/25] replay: global variables and function stubs,
Eric Blake <=
- [Qemu-devel] [RFC PATCH v4 04/25] sysemu: system functions for replay, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 05/25] replay: internal functions for replay log, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly, Pavel Dovgalyuk, 2014/11/07
- [Qemu-devel] [RFC PATCH v4 07/25] icount: implement icount requesting, Pavel Dovgalyuk, 2014/11/07