[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image |
Date: |
Mon, 10 Nov 2014 13:00:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/07/2014 12:39 PM, Kevin Wolf wrote:
> This is forbidden if the raw driver was probed.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/109 | 100 ++++++++++++++++++++++++++++++
> tests/qemu-iotests/109.out | 149
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 250 insertions(+)
> create mode 100755 tests/qemu-iotests/109
> create mode 100644 tests/qemu-iotests/109.out
Could you also add a test for writing an MBR/GRUB stage 1 sector into
the image? Since that is a very common guest action on initial install
of an OS into a blank disk, and also should NEVER match one of our
probes (assuming we never add support for a file format that resembles
an MBR master sector), it would be nice to ensure that our restrictions
against writing to sector 0 only fire when actually hitting a colliding
probe, and not for all writes. Likewise, maybe add a test for writing a
sector of all 0 or all FF.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images, (continued)
- [Qemu-devel] [PATCH v2 7/9] raw: Prohibit dangerous writes for probed images, Kevin Wolf, 2014/11/07
- [Qemu-devel] [PATCH v2 8/9] qemu-iotests: Fix stderr handling in common.qemu, Kevin Wolf, 2014/11/07
- [Qemu-devel] [PATCH v2 9/9] qemu-iotests: Test writing non-raw image headers to raw image, Kevin Wolf, 2014/11/07
- Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images, Eric Blake, 2014/11/10
- Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images, Markus Armbruster, 2014/11/11
- Re: [Qemu-devel] [PATCH v2 0/9] raw: Prohibit dangerous writes for probed images, Stefan Hajnoczi, 2014/11/13