[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks |
Date: |
Tue, 11 Nov 2014 10:42:30 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Nov 11, 2014 at 12:15:26PM +0100, Paolo Bonzini wrote:
>
>
> On 07/11/2014 17:04, Andrew Jones wrote:
> > See individual patches.
> >
> > Andrew Jones (3):
> > vl: fix max_cpus check
> > vl: sanity check cpu topology
> > vl: warn on topology <-> maxcpus mismatch
> >
> > vl.c | 38 ++++++++++++++++++++++++++++++++------
> > 1 file changed, 32 insertions(+), 6 deletions(-)
> >
>
> Looks good, but Eduardo should be the authority on this stuff.
Patch 1/3 is an obvious fix that should go to 2.2.
Patch 2/3 is fixing two diferent bugs. One fix is making QEMU abort when
I think it really should, but the second fix may cause a silent ABI
change.
Patch 3/3 is just an warning, but it is changing the meaning of the
"sockets" option (from "sockets with online CPUs" to "all available
sockets (even the empty ones)"), so I think it makes sense only after we
actually change its meaning in 2.3.
--
Eduardo
- [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology, (continued)
[Qemu-devel] [PATCH 3/3] vl: warn on topology <-> maxcpus mismatch, Andrew Jones, 2014/11/07
Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks, Paolo Bonzini, 2014/11/11
- Re: [Qemu-devel] [PATCH 0/3] vl: smp_parse sanity checks,
Eduardo Habkost <=