[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(fals
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false) |
Date: |
Tue, 11 Nov 2014 11:12:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/10/2014 06:45 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
Is it worth hoisting this one into 2.2 via the -trivial tree?
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index beb7187..ebf843f 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2718,9 +2718,9 @@ static int qcow2_amend_options(BlockDriverState *bs,
> QemuOpts *opts,
> error_report("Cannot change refcount entry width");
> return -ENOTSUP;
> } else {
> - /* if this assertion fails, this probably means a new option was
> + /* if this point is reached, this probably means a new option was
> * added without having it covered here */
> - assert(false);
> + abort();
> }
>
> desc++;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification, (continued)
- [Qemu-devel] [PATCH 11/21] iotests: Prepare for refcount_width option, Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 13/21] block: Add opaque value to the amend CB, Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 14/21] qcow2: Use error_report() in qcow2_amend_options(), Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/11/10
- Re: [Qemu-devel] [PATCH 15/21] qcow2: Use abort() instead of assert(false),
Eric Blake <=
- [Qemu-devel] [PATCH 16/21] qcow2: Split upgrade/downgrade paths for amend, Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 12/21] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 17/21] qcow2: Use intermediate helper CB for amend, Max Reitz, 2014/11/10
- [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment, Max Reitz, 2014/11/10