Re: [Qemu-devel] [PATCH 0/2] raw-posix: Get rid of FIEMAP

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 12/11/2014 20:27, Markus Armbruster wrote:
>> See PATCH 2/2 for rationale.
>> 
>> Would you like this included in 2.2?
>> 
>> Markus Armbruster (2):
>>   raw-posix: Fix comment for raw_co_get_block_status()
>>   raw-posix: SEEK_HOLE suffices, get rid of FIEMAP
>> 
>>  block/raw-posix.c | 132 
>> ++++++++++++++++++++----------------------------------
>>  1 file changed, 48 insertions(+), 84 deletions(-)
>> 
>
> Reviewed-by: Paolo Bonzini <address@hidden>
>
> though I'm not sure (and for once _I_ can say this to you :)) why you
> did a bigger change than just removing the call to try_fiemap and the
> definition of the function.

You and the other reviewers are right: I should split up 2/2 into a
minimal remove of FIEMAP and the cleanup.

Thanks!