[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/12] nvme: remove superfluous check
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 07/12] nvme: remove superfluous check |
Date: |
Mon, 17 Nov 2014 18:08:14 +0100 |
From: Gonglei <address@hidden>
Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
((n->bar.aqa >> AQA_ASQS_SHIFT) & AQA_ASQS_MASK) > 4095
is always false regardless of the values of its operands.
This occurs as the logical second operand of '||'.
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/block/nvme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index b6263dc..1327658 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -583,8 +583,7 @@ static int nvme_start_ctrl(NvmeCtrl *n)
NVME_CC_IOCQES(n->bar.cc) > NVME_CTRL_CQES_MAX(n->id_ctrl.cqes) ||
NVME_CC_IOSQES(n->bar.cc) < NVME_CTRL_SQES_MIN(n->id_ctrl.sqes) ||
NVME_CC_IOSQES(n->bar.cc) > NVME_CTRL_SQES_MAX(n->id_ctrl.sqes) ||
- !NVME_AQA_ASQS(n->bar.aqa) || NVME_AQA_ASQS(n->bar.aqa) > 4095 ||
- !NVME_AQA_ACQS(n->bar.aqa) || NVME_AQA_ACQS(n->bar.aqa) > 4095) {
+ !NVME_AQA_ASQS(n->bar.aqa) || !NVME_AQA_ACQS(n->bar.aqa)) {
return -1;
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/12] Coverity fixes for 2.2.0-rc2, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 01/12] libcacard: fix resource leak, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 02/12] l2tpv3: fix possible double free, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 03/12] l2tpv3: fix fd leak, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 04/12] mips_mipssim: fix use-after-free for filename, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 06/12] loader: fix NEGATIVE_RETURNS, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 05/12] qga: fix false negative argument passing, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 07/12] nvme: remove superfluous check,
Paolo Bonzini <=
- [Qemu-devel] [PULL 08/12] acl: fix memory leak, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 09/12] qemu-char: fix MISSING_COMMA, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 10/12] shpc: fix error propaagation, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 11/12] target-cris/translate.c: fix out of bounds read, Paolo Bonzini, 2014/11/17
- [Qemu-devel] [PULL 12/12] hcd-musb: fix dereference null return value, Paolo Bonzini, 2014/11/17
- Re: [Qemu-devel] [PULL 00/12] Coverity fixes for 2.2.0-rc2, Peter Maydell, 2014/11/17