[Qemu-devel] [Bug 1393486] [NEW] hw/virtio/virtio-rng.c:150: bad test ?

[dcb]

Public bug reported:

hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]

    if (!vrng->conf.period_ms > 0) {
        error_setg(errp, "'period' parameter expects a positive integer");
        return;
    }

Maybe better code

    if (vrng->conf.period_ms <= 0) {
        error_setg(errp, "'period' parameter expects a positive integer");
        return;
    }

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1393486

Title:
  hw/virtio/virtio-rng.c:150: bad test ?

Status in QEMU:
  New

Bug description:
  hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
  the left hand side of comparison [-Wlogical-not-parentheses]

      if (!vrng->conf.period_ms > 0) {
          error_setg(errp, "'period' parameter expects a positive integer");
          return;
      }

  Maybe better code

      if (vrng->conf.period_ms <= 0) {
          error_setg(errp, "'period' parameter expects a positive integer");
          return;
      }

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1393486/+subscriptions