Re: [Qemu-devel] [PATCH v4 34/47] Postcopy: Create a fault handler thread before marking the ram as userfault

[Dr. David Alan Gilbert]

* David Gibson (address@hidden) wrote:
> On Fri, Oct 03, 2014 at 06:47:40PM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> 
> This could do with a bit more rationale in the commit message.
> 
> Also is there a reason not to fold this with the patch originally
> marking the RAM as userfault?  IIRC that one wasn't partocularly long
> either.

I've merged it with 'ram_enable_notify to switch on userfault' and
it's commit message now reads.


 'Mark the area of RAM as 'userfault'
 Start up a fault-thread to handle any userfaults we might receive
 from it (to be filled in later)'

Dave

> 
> Otherwise
> 
> Reviewed-by: David Gibson <address@hidden>
> 
> -- 
> David Gibson                  | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au        | minimalist, thank you.  NOT _the_ 
> _other_
>                               | _way_ _around_!
> http://www.ozlabs.org/~dgibson


--
Dr. David Alan Gilbert / address@hidden / Manchester, UK