[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page re
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request |
|
Date: |
Wed, 19 Nov 2014 19:37:53 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* David Gibson (address@hidden) wrote:
> On Mon, Nov 17, 2014 at 07:07:33PM +0000, Dr. David Alan Gilbert wrote:
> > > And maybe this one too - I would have expected the rb names to have
> > > already been validated on the source machine at this stage.
> >
> > No to both:
> > I've been trying to avoid asserts in migration outgoing code, because
> > they shouldn't affect the state of your guest, so there's no reason
> > to kill off what might still be a viable running guest just because
> > migration failed.
>
> Ah, ok, that makes sense. Maybe adding something to the error message
> or a nearby comment indicating that if these happen it's certainly a
> bug, not the result of some external problem?
Done.
Dave
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK