[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/9] block: Factor bdrv_probe_all() out of find_i
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH v3 5/9] block: Factor bdrv_probe_all() out of find_image_format() |
Date: |
Thu, 20 Nov 2014 16:27:10 +0100 |
From: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block.c | 48 +++++++++++++++++++++++++++++++++++-------------
1 file changed, 35 insertions(+), 13 deletions(-)
diff --git a/block.c b/block.c
index a612594..a0051cb 100644
--- a/block.c
+++ b/block.c
@@ -648,11 +648,43 @@ BlockDriver *bdrv_find_protocol(const char *filename,
return NULL;
}
+/*
+ * Guess image format by probing its contents.
+ * This is not a good idea when your image is raw (CVE-2008-2004), but
+ * we do it anyway for backward compatibility.
+ *
+ * @buf contains the image's first @buf_size bytes.
+ * @buf_size is the buffer size in bytes (generally 2048, but can be smaller
+ * if the image file is smaller)
+ * @filename is its filename.
+ *
+ * For all block drivers, call the bdrv_probe() method to get its
+ * probing score.
+ * Return the first block driver with the highest probing score.
+ */
+static BlockDriver *bdrv_probe_all(const uint8_t *buf, int buf_size,
+ const char *filename)
+{
+ int score_max = 0, score;
+ BlockDriver *drv = NULL, *d;
+
+ QLIST_FOREACH(d, &bdrv_drivers, list) {
+ if (d->bdrv_probe) {
+ score = d->bdrv_probe(buf, buf_size, filename);
+ if (score > score_max) {
+ score_max = score;
+ drv = d;
+ }
+ }
+ }
+
+ return drv;
+}
+
static int find_image_format(BlockDriverState *bs, const char *filename,
BlockDriver **pdrv, Error **errp)
{
- int score, score_max;
- BlockDriver *drv1, *drv;
+ BlockDriver *drv;
uint8_t buf[2048];
int ret = 0;
@@ -675,17 +707,7 @@ static int find_image_format(BlockDriverState *bs, const
char *filename,
return ret;
}
- score_max = 0;
- drv = NULL;
- QLIST_FOREACH(drv1, &bdrv_drivers, list) {
- if (drv1->bdrv_probe) {
- score = drv1->bdrv_probe(buf, ret, filename);
- if (score > score_max) {
- score_max = score;
- drv = drv1;
- }
- }
- }
+ drv = bdrv_probe_all(buf, ret, filename);
if (!drv) {
error_setg(errp, "Could not determine image format: No compatible "
"driver found");
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/9] raw: Prohibit dangerous writes for probed images, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 1/9] qemu-io: Allow explicitly specifying format, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 2/9] qemu-iotests: Use qemu-io -f $IMGFMT, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 3/9] qemu-iotests: Add qemu-io format option in Python tests, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 4/9] qtests: Specify image format explicitly, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 5/9] block: Factor bdrv_probe_all() out of find_image_format(),
Kevin Wolf <=
- [Qemu-devel] [PATCH v3 6/9] block: Read only one sector for format probing, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 7/9] raw: Prohibit dangerous writes for probed images, Kevin Wolf, 2014/11/20
- Re: [Qemu-devel] [PATCH v3 7/9] raw: Prohibit dangerous writes for probed images, Stefan Hajnoczi, 2014/11/25
- [Qemu-devel] [PATCH v3 8/9] qemu-iotests: Fix stderr handling in common.qemu, Kevin Wolf, 2014/11/20
- [Qemu-devel] [PATCH v3 9/9] qemu-iotests: Test writing non-raw image headers to raw image, Kevin Wolf, 2014/11/20