[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migratio
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 33/47] Postcopy: Postcopy startup in migration thread |
Date: |
Thu, 20 Nov 2014 18:19:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 20/11/2014 18:12, Dr. David Alan Gilbert wrote:
> Trace added, and also moved as requested - was the request to move
> it just to elimintate the other DPRINTF?
Yes.
>> > Also what is 2/3/4? Is this just for debugging or is it part of the
>> > protocol?
> Debug; they're very useful for matching the debug streams up, especially
> when the timers on the two hosts are very different.
> (I'm up for suggestions on how to mark the 2/3/4 for debug more clearly,
> especially if it meant that it didn't make the ping (ne reqack) dedicated
> to debug).
>
No problem, as long as it's clear to the guy matching the code against
the debug output.
Paolo