[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qc
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qcow2_create2 |
|
Date: |
Thu, 20 Nov 2014 15:23:39 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/20/2014 10:06 AM, Max Reitz wrote:
> Add a refcount_order parameter to qcow2_create2(), use that value for
> the image header and for calculating the size required for
> preallocation.
>
> For now, always pass 4.
>
> This addition requires changes to the calculation of the file size for
> the "full" and "falloc" preallocation modes. That in turn is a nice
> opportunity to add a command about that calculation not necessarily
s/command/comment/
> being exact (and that being intentional).
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
But review still holds. :)
> ---
> block/qcow2.c | 46 +++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 35 insertions(+), 11 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v3 08/22] qcow2: More helpers for refcount modification, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 09/22] qcow2: Open images with refcount order != 4, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 12/22] qcow2: Allow creation with refcount order != 4, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 11/22] iotests: Prepare for refcount_width option, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 13/22] progress: Allow regressing progress, Max Reitz, 2014/11/20
[Qemu-devel] [PATCH v3 16/22] qcow2: Use abort() instead of assert(false), Max Reitz, 2014/11/20