[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings |
Date: |
Tue, 25 Nov 2014 14:42:29 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
Hi all,
this patch series fixes a cpu mapping leak in virtio-net.
The bug is caused by virtio_net_handle_ctrl: it maps the entire out_sg
iov, but then modifies it and reduces it (iov_discard_front), and only
unmap the reduced version of the iov.
This causes a crash when running on Xen, but the behaviour is obviously
incorrect without Xen too.
The patch series fixes the issue by allowing virtio_net_handle_ctrl to
unmap the original out_sg iov but still call virtqueue_fill and
virtqueue_flush on the modified iov.
The first three patches do not introduce any functional changes.
Stefano Stabellini (4):
introduce virtqueue_unmap_sg
use virtqueue_unmap_sg in virtqueue_fill
move virtqueue_unmap_sg calls from virtqueue_fill to virtqueue_push
virtio-net: do not leak cpu mappings
hw/net/virtio-net.c | 9 ++++++++-
hw/virtio/virtio.c | 43 ++++++++++++++++++++++++-------------------
include/hw/virtio/virtio.h | 2 ++
3 files changed, 34 insertions(+), 20 deletions(-)
- [Qemu-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings,
Stefano Stabellini <=
- [Qemu-devel] [PATCH 1/4] introduce virtqueue_unmap_sg, Stefano Stabellini, 2014/11/25
- [Qemu-devel] [PATCH 2/4] use virtqueue_unmap_sg in virtqueue_fill, Stefano Stabellini, 2014/11/25
- [Qemu-devel] [PATCH 4/4] virtio-net: do not leak cpu mappings, Stefano Stabellini, 2014/11/25
- [Qemu-devel] [PATCH 3/4] move virtqueue_unmap_sg calls from virtqueue_fill to virtqueue_push, Stefano Stabellini, 2014/11/25
- Re: [Qemu-devel] [Xen-devel] [PATCH 0/4] virtio-net: do not leak cpu mappings, Fabio Fantoni, 2014/11/25