Re: [Qemu-devel] [PATCH RFC v2 07/12] dataplane: allow virtio-1 devices

[Cornelia Huck]

On Tue, 25 Nov 2014 18:55:56 +0100
Greg Kurz <address@hidden> wrote:

> On Tue, 25 Nov 2014 14:24:18 +0100
> Cornelia Huck <address@hidden> wrote:
> 
> > Handle endianness conversion for virtio-1 virtqueues correctly.
> > 
> > Note that dataplane now needs to be built per-target.
> > 
> > Signed-off-by: Cornelia Huck <address@hidden>
> > ---
> 
> We still have the same error as in your previous post...
> 
> In file included from include/hw/virtio/dataplane/vring.h:23:0,
>                  from include/hw/virtio/virtio-scsi.h:21,
>                  from hw/virtio/virtio-pci.c:24:
> include/hw/virtio/virtio-access.h: In function ‘virtio_access_is_big_endian’:
> include/hw/virtio/virtio-access.h:28:15: error: attempt to use poisoned 
> "TARGET_WORDS_BIGENDIAN"
>  #elif defined(TARGET_WORDS_BIGENDIAN)

Grmpf, I thought I had fixed this. I'll do an update tomorrow.

> 
> Either build virtio-pci per-target or probably better move the target tainted
> accessors to another file.
> 
> >  hw/block/dataplane/virtio-blk.c     |    3 +-
> >  hw/scsi/virtio-scsi-dataplane.c     |    2 +-
> >  hw/virtio/Makefile.objs             |    2 +-
> >  hw/virtio/dataplane/Makefile.objs   |    2 +-
> >  hw/virtio/dataplane/vring.c         |   85 
> > +++++++++++++++++++----------------
> >  include/hw/virtio/dataplane/vring.h |   64 ++++++++++++++++++++++++--
> >  6 files changed, 113 insertions(+), 45 deletions(-)