[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential drivers |
Date: |
Thu, 27 Nov 2014 15:48:29 +0100 |
We can always assume raw, file and qcow2 being available; so do not use
bdrv_find_format() to locate their BlockDriver objects but statically
reference the respective objects.
Cc: address@hidden
Signed-off-by: Max Reitz <address@hidden>
---
block.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/block.c b/block.c
index 9d003bc..fbd7cb2 100644
--- a/block.c
+++ b/block.c
@@ -629,7 +629,7 @@ BlockDriver *bdrv_find_protocol(const char *filename,
}
if (!path_has_protocol(filename) || !allow_protocol_prefix) {
- return bdrv_find_format("file");
+ return bdrv_file;
}
p = strchr(filename, ':');
@@ -658,12 +658,7 @@ static int find_image_format(BlockDriverState *bs, const
char *filename,
/* Return the raw BlockDriver * to scsi-generic devices or empty drives */
if (bs->sg || !bdrv_is_inserted(bs) || bdrv_getlength(bs) == 0) {
- drv = bdrv_find_format("raw");
- if (!drv) {
- error_setg(errp, "Could not find raw image format");
- ret = -ENOENT;
- }
- *pdrv = drv;
+ *pdrv = bdrv_raw;
return ret;
}
@@ -1293,7 +1288,6 @@ int bdrv_append_temp_snapshot(BlockDriverState *bs, int
flags, Error **errp)
/* TODO: extra byte is a hack to ensure MAX_PATH space on Windows. */
char *tmp_filename = g_malloc0(PATH_MAX + 1);
int64_t total_size;
- BlockDriver *bdrv_qcow2;
QemuOpts *opts = NULL;
QDict *snapshot_options;
BlockDriverState *bs_snapshot;
@@ -1318,7 +1312,6 @@ int bdrv_append_temp_snapshot(BlockDriverState *bs, int
flags, Error **errp)
goto out;
}
- bdrv_qcow2 = bdrv_find_format("qcow2");
opts = qemu_opts_create(bdrv_qcow2->create_opts, NULL, 0,
&error_abort);
qemu_opt_set_number(opts, BLOCK_OPT_SIZE, total_size);
--
1.9.3
- [Qemu-devel] [PATCH v2 00/13] block: Various Coverity-spotted fixes, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 01/13] block: Make essential BlockDriver objects public, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential drivers,
Max Reitz <=
- [Qemu-devel] [PATCH v2 03/13] block/vvfat: qcow driver may not be found, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 04/13] block/nfs: Add create_opts, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 05/13] block: Check create_opts before image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 06/13] qemu-img: Check create_opts before image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 07/13] qemu-img: Check create_opts before image amendment, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 08/13] iotests: Only kill NBD server if it runs, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 09/13] iotests: Add test for unsupported image creation, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 10/13] qcow2: Prevent numerical overflow, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 12/13] qcow2: Respect bdrv_truncate() error, Max Reitz, 2014/11/27
- [Qemu-devel] [PATCH v2 11/13] qcow2: Flushing the caches in qcow2_close may fail, Max Reitz, 2014/11/27