[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 03/16] virtio: support more feature bits
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 03/16] virtio: support more feature bits |
Date: |
Thu, 27 Nov 2014 17:34:19 +0200 |
On Thu, Nov 27, 2014 at 04:16:36PM +0100, Cornelia Huck wrote:
> With virtio-1, we support more than 32 feature bits. Let's make
> vdev->guest_features depend on the number of supported feature bits,
> allowing us to grow the feature bits automatically.
>
> We also need to enhance the internal functions dealing with getting
> and setting features with an additional index field, so that all feature
> bits may be accessed (in chunks of 32 bits).
>
> vhost and migration have been ignored for now.
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> @@ -117,7 +125,7 @@ struct VirtIODevice
> uint8_t status;
> uint8_t isr;
> uint16_t queue_sel;
> - uint32_t guest_features;
> + uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS];
> size_t config_len;
> void *config;
> uint16_t config_vector;
Ugh.
That's quite tricky to use correctly.
Why don't we just make it uint64_t?
The only real issue is that DEFINE_PROP_BIT wants
a uint32_t.
But that's easy to fix: add DEFINE_PROP64_BIT
that is the same but handles a 64 bit array.
--
MST
- [Qemu-devel] [PATCH RFC v4 00/16] qemu: towards virtio-1 host support, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 04/16] s390x/virtio-ccw: fix check for WRITE_FEAT, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 05/16] virtio: introduce legacy virtio devices, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 06/16] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 07/16] dataplane: allow virtio-1 devices, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 08/16] s390x/css: Add a callback for when subchannel gets disabled, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 09/16] s390x/virtio-ccw: add virtio set-revision call, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 10/16] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/11/27
- [Qemu-devel] [PATCH RFC v4 11/16] virtio: disallow late feature changes for virtio-1, Cornelia Huck, 2014/11/27