qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] MinGW build


From: Peter Maydell
Subject: Re: [Qemu-devel] MinGW build
Date: Fri, 28 Nov 2014 08:41:18 +0000

On 28 November 2014 at 07:14, Stefan Weil <address@hidden> wrote:
> The libvixl code is correct, but the C++ compiler would need to be
> fixed. Here are some examples:
>
> disas/libvixl/a64/disasm-a64.cc:1340:57: warning: unknown conversion
> type character ā€˜lā€™ in format [-Wformat]
> disas/libvixl/a64/disasm-a64.cc:1340:57: warning: too many arguments for
> format [-Wformat-extra-args]
> disas/libvixl/a64/disasm-a64.cc:1492:42: warning: unknown conversion
> type character ā€˜lā€™ in format [-Wformat]
>
> That code uses PRIx64, so the format specifier is %llx which is correct.
> Obviously the C++ compiler ignores that QEMU uses ANSI format specifiers
> (compiler option -D__USE_MINGW_ANSI_STDIO=1) instead of the MS specific
> ones.

Lovely.

> A simple workaround for QEMU would just suppress -Wformat and
> -Wformat-extra-args for C++ code.

I'd prefer not to lose those (just because once you turn off a
warning it's never going to come back, practically speaking).
We could have a configure test that checked whether the c++
compiler understood %llx, maybe?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]