[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty |
Date: |
Fri, 28 Nov 2014 16:55:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Copying Luiz.
Max Reitz <address@hidden> writes:
> This series does not add new functionality. Adding a QMP monitor with
> prettily formatted JSON output can be done as follows:
>
> $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on
>
> However, this is rather cumbersome, so this series (its first patch)
> adds a shortcut in the form of the new command line option -qmp-pretty.
>
> Since the argument given to a monitor command line option (such as -qmp)
> is parsed depending on its prefix and probably also depending on the
> current phase of the moon, this is cleaner than trying to add a "switch"
> to -qmp itself (in the form of "-qmp stdio,pretty=on").
Yet another "convenience" option *groan*
Why can't we simply make -qmp set pretty=on and be done with it?
It's a convenience option, i.e. meant for humans, and why would humans
*not* want pretty=on?
Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty, Kevin Wolf, 2014/11/20
Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty,
Markus Armbruster <=