[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver
From: |
Jiri Slaby |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver |
Date: |
Wed, 03 Dec 2014 16:11:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/13/2014, 03:00 PM, Paolo Bonzini wrote:
>> +static void edu_dma_timer(void *opaque)
>> +{
>> + EduState *edu = opaque;
>> + bool raise_irq = false;
>> +
>> + qemu_mutex_lock(&edu->dma_mutex);
>
> dma_mutex and mutex and irq_mutex are not necessary. All I/O happens
> under the big QEMU lock (qemu_lock/unlock_iothread). I can certainly
> imagine that edu.c would be one of the first devices we make
> thread-safe, but... not yet. :)
Hi,
I finally got to it. I want to make sure that I understand this
correctly. So even timers are protected by the "BQL"?
thanks,
--
js
suse labs
- Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver,
Jiri Slaby <=