[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: fix memory leak
From: |
Gonglei |
Subject: |
Re: [Qemu-devel] [PATCH] spice: fix memory leak |
Date: |
Fri, 5 Dec 2014 13:01:14 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/12/5 12:59, Eric Blake wrote:
> On 12/04/2014 08:31 PM, address@hidden wrote:
>> From: Gonglei <address@hidden>
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() return NULL, and varriable
>
> s/return/returns/
> s/varriable/the variable/
>
>> cur_item going out of scope leaks the storage it points to.
>> Let's check for errors in advance avoid memory leak.
>
> s/avoid/to avoid a/
>
>>
>> Suggested-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Gonglei <address@hidden>
>> ---
>> ui/spice-core.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>
> Maintainer can fix up commit message typos.
> Reviewed-by: Eric Blake <address@hidden>
>
Thanks, Eric :)
Regards,
-Gonglei