[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kernel PATCH v2 2/2] devicetree: document ARM bindings
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [kernel PATCH v2 2/2] devicetree: document ARM bindings for QEMU's Firmware Config interface |
Date: |
Fri, 05 Dec 2014 20:04:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/05/14 19:57, Peter Maydell wrote:
> On 30 November 2014 at 16:51, Laszlo Ersek <address@hidden> wrote:
>> +Example:
>> +
>> +/ {
>> + #size-cells = <0x2>;
>> + #address-cells = <0x2>;
>> +
>> + address@hidden {
>> + compatible = "qemu,fw-cfg-mmio";
>> + reg = <0x0 0x9020000 0x0 0x1000>;
>> + };
>
> I've just noticed that this example claims a register
> region size of 0x1000. This seems wrong, because the
> underlying device doesn't have a register range that
> big. Surely this should be a size of 0x3 ?
Arnd said I should round up the region to 0x1000.
http://thread.gmane.org/gmane.linux.drivers.devicetree/101173/focus=101176
If that's incorrect I'd prefer to post incremental patches, because 4
other series already depend on this kernel docs patch.
Thanks
Laszlo