Re: [Qemu-devel] [PATCH 0/5] bootdevice: Refactor and improvement

[Gonglei]

On 2014/12/4 19:19, Gonglei (Arei) wrote:

> From: Gonglei <address@hidden>
> 
> Patch 1 just move boot order related code to bootdevice.c.
> Patch 2,3,5 add an argument to corresponding functions.
> This way, we can propagate the error messages to the caller.
> Maybe somebody will say we will remove the legacy boot order
> in the future, instead of using bootindex. But at present,
> for PPC, the have no way support bootindex, ARM on the flight
> (Laszlo Ersek) as far as know.
> 
> After this work, we can easily to add QMP command for existing
> HMP command 'boot_set' if we have a requirement.
> 
> Gonglei (5):
>   bootdevice: move code about bootorder from vl.c to bootdevice.c
>   bootdevice: add Error **errp argument for validate_bootdevices()
>   bootdevice: add Error **errp argument for qemu_boot_set()
>   bootdevice: add validate check for qemu_boot_set()
>   bootdevice: add Error **errp argument for QEMUBootSetHandler
> 
>  bootdevice.c            | 73 ++++++++++++++++++++++++++++++++++++++++++++++
>  hw/i386/pc.c            | 21 ++++++--------
>  hw/ppc/mac_newworld.c   |  4 +--
>  hw/ppc/mac_oldworld.c   |  5 ++--
>  hw/sparc/sun4m.c        |  4 +--
>  hw/sparc64/sun4u.c      |  4 +--
>  include/hw/hw.h         |  6 ----
>  include/sysemu/sysemu.h |  7 +++++
>  monitor.c               | 14 ++++-----
>  vl.c                    | 77 
> +++++++++----------------------------------------
>  10 files changed, 116 insertions(+), 99 deletions(-)
> 

Any comments and/or Acks will be appreciated.
Then I'll send a pull request if no one is against  this :)

Regards,
-Gonglei