Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

[Gerd Hoffmann]

  Hi,

> That's not a correct interpretation of the auth values - tls and x509 are
> not separate auth codes. VNC has one set of primary auth codes really
> 
>   none, vnc, vencrypt

Well, the source code also has (see vnc_auth_name in ui/vnc.c):

ra2, ra2ne, tight, ultra, tls, sasl

> If using the vencrypt option there are a number of sub-auth codes
> 
>    tls-none, tls-vnc, tls-plain, tls-sasl x509-none, x509-vnc, x509-plain, 
> x509-sasl

So better add a 'vencrypt-subauth' enum with this list?

cheers,
  Gerd