[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own f
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file |
Date: |
Tue, 16 Dec 2014 01:59:01 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 16.12.14 01:43, David Gibson wrote:
> At the moment the RTAS (firmware/hypervisor) time of day functions are
> implemented in spapr_rtas.c along with a bunch of other things. Since
> we're going to be expanding these a bit, move the RTAS RTC related code
> out into new file spapr_rtc.c. Also add its own initialization function,
> spapr_rtc_init() called from the main machine init routine.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/Makefile.objs | 2 +-
> hw/ppc/spapr.c | 3 ++
> hw/ppc/spapr_rtas.c | 49 -----------------------------
> hw/ppc/spapr_rtc.c | 83
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> include/hw/ppc/spapr.h | 1 +
> 5 files changed, 88 insertions(+), 50 deletions(-)
> create mode 100644 hw/ppc/spapr_rtc.c
>
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index 19d9920..437955d 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -3,7 +3,7 @@ obj-y += ppc.o ppc_booke.o
> # IBM pSeries (sPAPR)
> obj-$(CONFIG_PSERIES) += spapr.o spapr_vio.o spapr_events.o
> obj-$(CONFIG_PSERIES) += spapr_hcall.o spapr_iommu.o spapr_rtas.o
> -obj-$(CONFIG_PSERIES) += spapr_pci.o
> +obj-$(CONFIG_PSERIES) += spapr_pci.o spapr_rtc.o
> ifeq ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), yyy)
> obj-y += spapr_pci_vfio.o
> endif
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 30de25d..16377a3 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1446,6 +1446,9 @@ static void ppc_spapr_init(MachineState *machine)
> /* Set up EPOW events infrastructure */
> spapr_events_init(spapr);
>
> + /* Set up the RTC RTAS interfaces */
> + spapr_rtc_init();
Do you think we could make it a device instead?
Alex
- [Qemu-devel] [PATCH 0/5] pseries: Fix and extend PAPR RTC implementation, David Gibson, 2014/12/15
- [Qemu-devel] [PATCH 2/5] pseries: Add spapr_rtc_read() helper function, David Gibson, 2014/12/15
- [Qemu-devel] [PATCH 5/5] pseries: Make RTAS time of day functions respect -rtc options, David Gibson, 2014/12/15
- [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, David Gibson, 2014/12/15
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file,
Alexander Graf <=
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, David Gibson, 2014/12/15
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, Alexander Graf, 2014/12/16
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, David Gibson, 2014/12/18
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, Alexander Graf, 2014/12/18
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, David Gibson, 2014/12/19
- Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file, Alexander Graf, 2014/12/19
[Qemu-devel] [PATCH 3/5] pseries: Add more parameter validation in RTAS time of day functions, David Gibson, 2014/12/15
[Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property, David Gibson, 2014/12/15