qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mir


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration
Date: Tue, 16 Dec 2014 10:40:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 2014-11-27 at 10:40, Vladimir Sementsov-Ogievskiy wrote:
Mirror and migration use dirty bitmaps for their purposes, and since
commit [block: per caller dirty bitmap] they use their own bitmaps, not
the global one. But they use old functions bdrv_set_dirty and
bdrv_reset_dirty, which change all dirty bitmaps.

Named dirty bitmaps series by Fam and Snow are affected: mirroring and
migration will spoil all (not related to this mirroring or migration)
named dirty bitmaps.

This patch fixes this by adding bdrv_set_dirty_bitmap and
bdrv_reset_dirty_bitmap, which change concrete bitmap. Also, to prevent
such mistakes in future, old functions bdrv_(set,reset)_dirty are made
static, for internal block usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
CC: John Snow <address@hidden>
CC: Fam Zheng <address@hidden>
CC: Denis V. Lunev <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
---

This patch conflicts with
[PATCH v8 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap
by John Snow, which introduces bdrv_reset_dirty_bitmap too, but it resets the 
whole
bitmap, not specified sectors range.

  block-migration.c     |  5 +++--
  block.c               | 23 ++++++++++++++++++++---
  block/mirror.c        | 11 +++++++----
  include/block/block.h |  6 ++++--
  4 files changed, 34 insertions(+), 11 deletions(-)

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block



reply via email to

[Prev in Thread] Current Thread [Next in Thread]