[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup"
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup" |
Date: |
Wed, 17 Dec 2014 11:44:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Fam Zheng <address@hidden> writes:
> v3: Address Eric's comments on documentation.
> Squashed 3/4 into 2/4.
>
> v2: Address Markus' and Eric's comments:
> Fix qapi schema documentation.
> Fix versioning of transactions.
> Improve test case code by dropping inelegnet bool.
>
> The existing drive-backup command accepts a target file path, but that
> interface provides little flexibility on the properties of target block
> device,
> compared to what is possible with "blockdev-add", "drive_add" or "-drive".
>
> This is also a building block to allow image fleecing (creating a point in
> time
> snapshot and export with nbd-server-add).
>
> (For symmetry, blockdev-mirror will be added in a separate series.)
Trivial typos/pastos in PATCH 1, and a question on GenericError. If you
address these, you can add my R-by.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup",
Markus Armbruster <=