Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

[John Snow]

On 12/17/2014 04:37 AM, Paolo Bonzini wrote:
> On 17/12/2014 09:23, Markus Armbruster wrote:
> > I had to read this twice to even guess how this is related to the stated
> > subject "ide: rerror and werror support for IDE and AHCI" :)
> >
> > IDE already supports rerror and werror.  I guess this series fixes
> > migration bugs that can bite when rerror/werror=stop.  Correct?
>
> IDE over PCI supports rerror and werror.  IDE over ISA does not.
>
> This series makes it possible to support it very easily, see patch 13.
>
> Paolo

Yes, sorry -- rerror=stop/werror=stop already worked for PCI/BMDMA, but 
this series as a whole unifies the resume pathways and irons out some 
migration issues.

Most notably, as Paolo states, this fixes ISA and my later patches fix 
AHCI. AHCI tests are still dependent upon enabling migration, so those 
aren't here yet, but I sat on this series until I convinced myself that 
AHCI was working too, hence the delay.

The practical upshot is that rerror/werror work for all the acronyms 
listed using newly unified code pathways.

--js