Re: [Qemu-devel] [PATCH v3] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

[Peter Maydell]

On 2 January 2015 at 16:47, Programmingkid <address@hidden> wrote:
> On Jan 2, 2015, at 9:38 AM, Stefan Hajnoczi wrote:
>> Plain text emails are usually wrapped at 72 characters.  It makes it
>> easier to read the git log if you wrap lines.
>
> On my email program, the lines just wrap at the width of the window they are 
> in.
> Maybe there is a feature in your email program to wrap lines.

The standard git tools for applying patches from email don't
wrap lines -- they assume that the sender has inserted manual
carriage returns at the right places (and that if there are
long lines it's because they should be long, for instance to
avoid quoted command lines being wrapped). This is just one of
those things where you need to follow the conventions to make
life easier for the recipients, I'm afraid.

>> Good job braving the nasty nest of #ifdefs in raw_getlength() :).  The
>> code change looks good.  Minor changes below - normally I'd make them
>> while merging your patch but I don't compile QEMU on Mac so I can't
>> compile test it.  Please send a new version of this patch.
>
> Thank you for the kind remarks. I can't believe some of the code in that file 
> was
> actually committed. I think someone should remove most of the #ifdefs and
> pretty up the file. I would probably do something like mac_raw_getlength(),
> windows_raw_getlength(), linux_raw_getlength(), sun_raw_getlength()...
> Then just use the correct function for the host.

Yes; you can see already that half of the BSDs have been abstracted
out. The difficulty is that to a first approximation none of the
regular developers here uses anything except Linux, and it's always
a bit tricky to make changes which you aren't testing...

thanks
-- PMM