[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode i
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly |
|
Date: |
Tue, 6 Jan 2015 11:57:54 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, 01/05 12:42, David Morrison wrote:
> Fixed the decoding of "system" instructions (starting with 0x2)
> in dec_sys() in translate.c. In particular, the l.trap instruction
> is now correctly decoded, which enables for singlestepping and
> breakpoints to be set in GDB.
Missing a Signed-off-by: line here.
Fam
> ---
> target-openrisc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
> index 407bd97..d36278f 100644
> --- a/target-openrisc/translate.c
> +++ b/target-openrisc/translate.c
> @@ -1320,7 +1320,7 @@ static void dec_sys(DisasContext *dc, uint32_t insn)
> #ifdef OPENRISC_DISAS
> uint32_t K16;
> #endif
> - op0 = extract32(insn, 16, 8);
> + op0 = extract32(insn, 16, 10);
> #ifdef OPENRISC_DISAS
> K16 = extract32(insn, 0, 16);
> #endif
> --
> 2.2.1
>
>