[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetCli
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos |
Date: |
Tue, 6 Jan 2015 12:59:07 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Dec 23, 2014 at 05:53:19PM +0100, Paolo Bonzini wrote:
> All NICs have a cleanup function that, in most cases, zeroes the pointer
> to the NICState. In some cases, it frees data belonging to the NIC.
>
> However, this function is never called except when exiting from QEMU.
> It is not necessary to NULL pointers and free data here; the right place
> to do that would be in the device's unrealize function, after calling
> qemu_del_nic. Zeroing the NIC multiple times is also wrong for multiqueue
> devices.
>
> This cleanup function gets in the way of making the NetClientStates for
> the NIC hold an object_ref reference to the object, so get rid of it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/net/allwinner_emac.c | 8 --------
> hw/net/cadence_gem.c | 9 ---------
> hw/net/dp8393x.c | 11 -----------
> hw/net/e1000.c | 9 ---------
> hw/net/eepro100.c | 8 --------
> hw/net/etraxfs_eth.c | 13 -------------
> hw/net/fsl_etsec/etsec.c | 6 ------
> hw/net/lan9118.c | 8 --------
> hw/net/lance.c | 8 --------
> hw/net/mcf_fec.c | 8 --------
> hw/net/milkymist-minimac2.c | 8 --------
> hw/net/mipsnet.c | 8 --------
> hw/net/ne2000-isa.c | 8 --------
> hw/net/ne2000.c | 8 --------
> hw/net/opencores_eth.c | 5 -----
> hw/net/pcnet-pci.c | 8 --------
> hw/net/pcnet.c | 5 -----
> hw/net/pcnet.h | 1 -
> hw/net/rtl8139.c | 8 --------
> hw/net/smc91c111.c | 8 --------
> hw/net/spapr_llan.c | 8 --------
> hw/net/stellaris_enet.c | 8 --------
> hw/net/virtio-net.c | 8 --------
> hw/net/vmxnet3.c | 7 -------
> hw/net/xgmac.c | 8 --------
> hw/net/xilinx_axienet.c | 9 ---------
> hw/net/xilinx_ethlite.c | 8 --------
> 27 files changed, 211 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
pgpc9btEpaOP3.pgp
Description: PGP signature