[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device |
Date: |
Tue, 6 Jan 2015 15:12:20 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jan 05, 2015 at 06:24:58PM -0800, address@hidden wrote:
> From: Scott Feldman <address@hidden>
>
> Rocker is a simulated ethernet switch device. The device supports up to 62
> front-panel ports and supports L2 switching and L3 routing functions, as well
> as L2/L3/L4 ACLs. The device presents a single PCI device for each switch,
> with a memory-mapped register space for device driver access.
>
> Rocker device is invoked with -device, for example a 4-port switch:
>
> -device rocker,name=sw1,len-ports=4,ports[0]=dev0,ports[1]=dev1, \
> ports[2]=dev2,ports[3]=dev3
>
> Each port is a netdev and can be paired with using -netdev id=<port name>.
This design looks good, it fits the QEMU network subsystem.
Please follow QEMU coding style, for example, using typedefs for structs
instead of "struct tag". Details are in ./HACKING, ./CODING_STYLE, and
you can scan patches with QEMU's scripts/checkpatch.pl.
pgpp9kP0kEarh.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v2 02/10] net: add MAC address string printer, (continued)
- [Qemu-devel] [PATCH v2 02/10] net: add MAC address string printer, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 06/10] pci: add network device class 'other' for network switches, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 04/10] rocker: add register programming guide, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 10/10] MAINTAINERS: add rocker, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 09/10] rocker: add tests, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support, sfeldma, 2015/01/05
- [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device, sfeldma, 2015/01/05
- Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device,
Stefan Hajnoczi <=