Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter

[John Snow]

On 01/08/2015 05:29 PM, Eric Blake wrote:
> On 01/08/2015 02:51 PM, John Snow wrote:
> > CC'ing Eric Blake for monitor interface review.
>
> Indeed, I already saw and reviewed the monitor interface in a mail dated
> Dec 11.

Sorry, I missed that one. Thank you, though :)

> > On 12/11/2014 09:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> > > Add dirty parameter to qmp-migrate command. If this parameter is true,
> > > block-migration.c will migrate dirty bitmaps. This parameter can be used
> > > without "blk" parameter to migrate only dirty bitmaps, skipping block
> > > migration.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> > > +        .args_type  = "detach:-d,blk:-b,inc:-i,dirty:-D,uri:s",
> > >            .params     = "[-d] [-b] [-i] uri",
> >
> > ^ Missing the new -D parameter?
>
> But I missed this point :)  (I've been known to pay less attention to
> HMP than I do to QMP)

Sometimes robots miss things, it's fine ;)

--
—js