[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user inpu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input |
Date: |
Mon, 12 Jan 2015 13:25:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> +void qemu_input_event_send(QemuConsole *src, InputEvent *evt)
> {
> - QemuInputHandlerState *s;
> -
> if (!runstate_is_running() && !runstate_check(RUN_STATE_SUSPENDED)) {
> return;
> }
>
> + if (replay_mode == REPLAY_MODE_PLAY) {
> + /* Nothing */
> + } else if (replay_mode == REPLAY_MODE_RECORD) {
> + replay_add_input_event(evt);
> + } else {
> + qemu_input_event_send_impl(src, evt);
> + }
Similar to other cases, please wrap this into a single function,
something like
if (replay_handle_input_event(evt)) {
return;
}
/* ... original contents of qemu_input_event_send ... */
Paolo
- [Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves, (continued)
- [Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 17/21] replay: replay aio requests, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 18/21] replay: thread pool, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 19/21] replay: initialization and deinitialization, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 20/21] replay: command line options, Pavel Dovgalyuk, 2015/01/12
- [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input, Pavel Dovgalyuk, 2015/01/12
- Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input,
Paolo Bonzini <=
Re: [Qemu-devel] [RFC PATCH v7 00/21] Deterministic replay core, Paolo Bonzini, 2015/01/12